Generic Code cleanup, CI fix, Charater encoding fix#194
Open
EinDev wants to merge 9 commits intoSkQuery:mainfrom
Open
Generic Code cleanup, CI fix, Charater encoding fix#194EinDev wants to merge 9 commits intoSkQuery:mainfrom
EinDev wants to merge 9 commits intoSkQuery:mainfrom
Conversation
# Conflicts: # .github/workflows/gradle.yml # build.gradle # src/main/java/com/skquery/skquery/elements/conditions/CondFileExistance.java # src/main/java/com/skquery/skquery/elements/expressions/ExprMessageFormat.java # src/main/java/com/skquery/skquery/elements/expressions/ExprYaml.java # src/main/java/com/w00tmast3r/skquery/elements/conditions/CondIsWithin.java # src/main/java/com/w00tmast3r/skquery/elements/expressions/ExprComparisons.java
Member
|
Needs updating, or needs permission to allow collaborators to update so that I can resolve conflicts for example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally made this change in order to bump the Skript version, which you have now made in the official version as well.
But since i noticed some stuff along the way, i thought i might share my thoughts instead of just trashing my work.