adding support for sepa complex field in payment_method#60
Merged
rsomavarapu-sift merged 1 commit intopayments_fintech_java_changesfrom Aug 26, 2021
Merged
Conversation
natashasehgal
suggested changes
Aug 25, 2021
Contributor
natashasehgal
left a comment
There was a problem hiding this comment.
Changing path segment to 206 is causing test failures. Can you update that? Can take a pull from #59 which has all the v206 related test fixes
0584f96 to
bc150b4
Compare
Contributor
Author
|
@natashasehgal as discussed offline, I changed the base branch. |
Contributor
|
LGTM! |
natashasehgal
approved these changes
Aug 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
sepacomplex field to support SEPA payment method which can be used for various fintech purposes in the future like feature extraction, reporting, workflow management, etc.Technical Overview
$sepacomplex field which contains$sepa_type,$account_holder_name,$shortened_iban,$bic, and$mandate_idfields which would be part of$payment_methodfield.Testing Plan
Deployment
(Once all the fintech-related changes are merged)
Note - I will update the changelog during the last PR as it would cause conflicts now.