Merged
Conversation
added 5 commits
October 14, 2019 20:28
- Add missing check to StringMatches - Add more unit testing for StringMatches
- Update Mono version checker to check length better - Add new event calling system, this should reduce duplicated code - Update a couple info messages - Change the server start-up crash message - Check if a command is already registered before registering - Safer and more optimized OutputHandler index checks - Modify CompareVersion to check version length as well as the numbers
- Add startup fail configs - Add "server_start_retry" - Add "server_start_retry_delay" - Change all usages of "Path.DirectorySeparatorChar" for combining paths to Path.Combine()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config Additions
server_start_retryserver_start_retry_delayBug Fixes
Misc Changes
Path.DirectorySeparatorCharfor combining paths toPath.Combine()