Skip to content

Add base 64 encoding support#140

Merged
jbrichau merged 4 commits intoSeasideSt:masterfrom
marschall:base64Encode
Aug 26, 2022
Merged

Add base 64 encoding support#140
jbrichau merged 4 commits intoSeasideSt:masterfrom
marschall:base64Encode

Conversation

@marschall
Copy link
Contributor

No description provided.

@marschall marschall added the CampSmalltalk 2022 Issues worked on at CampSmalltalk 2022 in Novi Sad label Aug 21, 2022
@jbrichau
Copy link
Member

To merge this, we need an implementation on all tested platforms.

@marschall
Copy link
Contributor Author

To merge this, we need an implementation on all tested platforms.

Alright, I'll see if I can do something.

@jbrichau
Copy link
Member

@marschall can I write to your fork? I guess it will be easier if I take a stab at the GemStone implementations?

@marschall
Copy link
Contributor Author

@marschall can I write to your fork? I guess it will be easier if I take a stab at the GemStone implementations?

Sure, please go ahead.

@marschall
Copy link
Contributor Author

I just noted Gemstone 3.5 added support for Base64

https://downloads.gemtalksystems.com/docs/GemStone64/3.5.x/GS64-ReleaseNotes-3.5/3-ProgrammingChanges.htm#pgfId-1968321

I wonder how much back we want to support, same for Squeak and Pharo.

@jbrichau
Copy link
Member

jbrichau commented Aug 25, 2022

I just noted Gemstone 3.5 added support for Base64

Actually, Base64 encoding was part of the GLASS project since a long time. See https://github.com/glassdb/glass/tree/044b42d4601d5ca3789ade45c7a3e6bcdca9c7f9/repository/Squeak.package/Base64MimeConverter.class

https://downloads.gemtalksystems.com/docs/GemStone64/3.5.x/GS64-ReleaseNotes-3.5/3-ProgrammingChanges.htm#pgfId-1968321

I wonder how much back we want to support, same for Squeak and Pharo.

I just recently dropped Pharo 6 but we could start dropping Pharo 7 as well. I think Pharo 8 is best kept working for a little while longer. Most people are on Pharo 9 or even Pharo 10.

The Gemstone versions are probably soon going to be cut off since anything older than 3.5 is not running anymore on ubuntu 18, which is not going to be running on github actions anymore on dec 1st... I did not count on that sooner than the real standard support enddate (april 2023) but ok...

@jbrichau jbrichau merged commit 3760bc7 into SeasideSt:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CampSmalltalk 2022 Issues worked on at CampSmalltalk 2022 in Novi Sad

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants