Fix stage header when dark-www and scratch3to2 are active simultaneously#8849
Fix stage header when dark-www and scratch3to2 are active simultaneously#8849mxmou merged 6 commits intoScratchAddons:masterfrom
dark-www and scratch3to2 are active simultaneously#8849Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the scratch3to2 addon to properly integrate with the dark-www addon by applying dark theme colors to the stage header when both addons are simultaneously enabled. The change replaces hard-coded gradient and border colors with CSS variables from dark-www, ensuring visual consistency across the interface.
Changes:
- Modified stage header styling to use
dark-wwwCSS variables for background and border colors - When
dark-wwwis enabled, the stage header will display with a solid background color matching the page theme instead of the original white-to-gray gradient
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mxmou
left a comment
There was a problem hiding this comment.
This will remove the gradient even when dark-www is set to the Scratch 2.0 preset, which is probably quite commonly used together with scratch3to2. I think it's better to have two versions of the gradient (light and dark) and switch between them based on the page background color.
|
@mxmou I've now updated it to use the colors from the |
|
That's better, but the gradient still isn't as noticeable as before with the 2.0 preset. Instead of
|
That's funny, I searched for this for 10 minutes without any results. Thank you. |
Resolves https://discord.com/channels/806602307750985799/1469856099590213683
Changes
Updated the
scratch3to2addon's userstyle to apply the page background and border colors fromdark-wwwon the stage header, if the latter is enabled. Ifdark-wwwis enabled, the gradient uses the colors from "Page background" and a darker variant.dark-wwwdisableddark-wwwenabledReason for changes
This change ensures that colors are consistent when both
dark-wwwandscratch3to2are enabled.Tests
Tested on Microsoft Edge 145.0.3800.65.