Fix premature lock status mutation in RedisLockRepository.AcquireAsync#35
Merged
Merged
Conversation
Move Status=Acquired assignment to after StringSetAsync confirms success. Previously the status was set before the Redis SET NX operation, leaving the lock object in Acquired state even when acquisition failed. Also update the serialized value in Redis to reflect the correct status. Closes #32
Sarmkadan
commented
May 21, 2026
Sarmkadan
left a comment
Owner
Author
There was a problem hiding this comment.
The fix is correct. The second StringSetAsync with When.Exists is a nice touch - ensures Redis and the in-memory object are consistent. The race window between SET NX and the update SET is negligible since the lock is already held.
Sarmkadan
commented
May 21, 2026
Sarmkadan
left a comment
Owner
Author
There was a problem hiding this comment.
The fix is correct. The second StringSetAsync with When.Exists is a nice touch - ensures Redis and the in-memory object are consistent. The race window between SET NX and the update SET is negligible since the lock is already held.
Sarmkadan
added a commit
that referenced
this pull request
Jul 11, 2026
) Move Status=Acquired assignment to after StringSetAsync confirms success. Previously the status was set before the Redis SET NX operation, leaving the lock object in Acquired state even when acquisition failed. Also update the serialized value in Redis to reflect the correct status. Closes #32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32
Bug:
@lock.Statuswas set toAcquiredbefore theStringSetAsync(... When.NotExists)call. On failed acquisition, the lock object hadStatus=Acquireddespite not owning the lock.Fix:
Status=Acquiredafter confirmingsuccess == trueWhen.ExistsThe extra SET (with
When.Exists) ensures the stored lock value in Redis reflects the actual acquired status, which matters for monitoring tools that inspect lock entries directly.