Extra SBND CRT Branches by henrylay97 · Pull Request #632 · SBNSoftware/sbncode

henrylay97 · 2026-02-19T14:16:00Z

Description

I am starting to put together slides and PRs to preserve work of mine that lives offline before I leave.

The SBND CRT information in the CAFs is missing a few little pieces that are useful to analyzers (and simple to add as they are already present in the reconstruction objects).

The tagger variable (which wall) for the CRTSpacePoints
The number of contributing hits variable for the CRTSpacePoints
The vector of taggers variable (which walls) for the CRTTrack
Boolean fields to quickly establish whether or not a CRT-TPC match is present.

This PR alters CAFMaker in order to fill these new branches.

Accompanying PR: SBNSoftware/sbnanaobj#186
It is documented in slides: https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=45715

Have you added a label? (bug/enhancement/physics etc.)
Have you assigned at least 1 reviewer?
Is this PR related to an open issue / project?
Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

Li-Jiaoyang97

Everything looks good to me, thanks again Henry!

kjplows · 2026-03-12T12:55:51Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbnanaobj#186 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_03

FNALbuild · 2026-03-12T13:45:26Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-03-12T13:53:32Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-03-12T13:56:51Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-12T13:57:16Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-12T14:00:07Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-12T14:01:18Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

kjplows · 2026-03-12T16:55:58Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_15_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbnanaobj#186 SBNSoftware/sbn*@SBN_SUITE_v10_15_00

FNALbuild · 2026-03-12T17:11:36Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-03-12T17:19:09Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-03-12T17:24:22Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-12T17:25:00Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-12T17:39:44Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-12T18:23:31Z

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

PetrilloAtWork

I have some technical recommendations to be considered, but no critical showstopper.

sbncode/CAFMaker/CAFMaker_module.cc

PetrilloAtWork · 2026-03-12T18:21:04Z

sbncode/CAFMaker/FillReco.cxx

  }

  void FillCRTSpacePoint(const sbnd::crt::CRTSpacePoint &spacepoint,
+                         const art::Ptr<sbnd::crt::CRTCluster> &cluster,


I recommend the interface to pass the object directly instead of its art pointer:

Suggested change

const art::Ptr<sbnd::crt::CRTCluster> &cluster,

const sbnd::crt::CRTCluster &cluster,

That allows in general the use of the function even when an art pointer is not available.
This change should be propagated as upstream as possible (i.e. to FillTrackCRTSpacePoint() interface too).

Have done so. It results in moving the dereferencing up to CAFMaker_module.cc. There's probably a neater way of doing that but I'm in a bit of a time crunch.

Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>

henrylay97

Thanks Gianluca, have responded to all the comments.

henrylay97 · 2026-03-13T11:15:20Z

sbncode/CAFMaker/FillReco.cxx

  }

  void FillCRTSpacePoint(const sbnd::crt::CRTSpacePoint &spacepoint,
+                         const art::Ptr<sbnd::crt::CRTCluster> &cluster,


Have done so. It results in moving the dereferencing up to CAFMaker_module.cc. There's probably a neater way of doing that but I'm in a bit of a time crunch.

kjplows · 2026-03-13T11:57:45Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_15_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbnanaobj#186 SBNSoftware/sbn*@SBN_SUITE_v10_15_00

FNALbuild · 2026-03-13T12:16:12Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-03-13T12:16:49Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-03-13T12:25:32Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-13T12:26:25Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-13T12:44:26Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-13T13:05:50Z

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

PetrilloAtWork

Thank you for the changes.

henrylay97 added 2 commits February 17, 2026 04:54

Fill new fields for SBND CRT

e8db3c5

Fill new field for easily flagging CRT-matched tracks in SBND

5530db9

henrylay97 requested review from JosiePaton and PetrilloAtWork February 19, 2026 14:16

henrylay97 self-assigned this Feb 19, 2026

henrylay97 added the enhancement New feature or request label Feb 19, 2026

henrylay97 mentioned this pull request Feb 19, 2026

Extra SBND CRT Branches SBNSoftware/sbnanaobj#186

Open

4 tasks

kjplows added this to SBN software development Mar 5, 2026

kjplows moved this to Open pull requests in SBN software development Mar 5, 2026

kjplows requested review from Li-Jiaoyang97 and removed request for JosiePaton March 5, 2026 11:41

Li-Jiaoyang97 reviewed Mar 5, 2026

View reviewed changes

Li-Jiaoyang97 approved these changes Mar 5, 2026

View reviewed changes

kjplows moved this from Open pull requests to Urgent checks in SBN software development Mar 12, 2026

PetrilloAtWork reviewed Mar 12, 2026

View reviewed changes

Apply good suggestions from Gianluca

fa6d0fc

Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>

Make dereferencing work

3ab2514

henrylay97 commented Mar 13, 2026

View reviewed changes

kjplows moved this from Urgent checks to To merge in SBN software development Mar 13, 2026

PetrilloAtWork self-requested a review March 13, 2026 14:20

PetrilloAtWork approved these changes Mar 13, 2026

View reviewed changes

	const art::Ptr<sbnd::crt::CRTCluster> &cluster,
	const sbnd::crt::CRTCluster &cluster,

Conversation

henrylay97 commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Li-Jiaoyang97 left a comment

Choose a reason for hiding this comment

Uh oh!

kjplows commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

kjplows commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

PetrilloAtWork left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PetrilloAtWork Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

henrylay97 Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

henrylay97 left a comment

Choose a reason for hiding this comment

Uh oh!

henrylay97 Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

kjplows commented Mar 13, 2026

Uh oh!

FNALbuild commented Mar 13, 2026

Uh oh!

FNALbuild commented Mar 13, 2026

Uh oh!

FNALbuild commented Mar 13, 2026

Uh oh!

FNALbuild commented Mar 13, 2026

Uh oh!

FNALbuild commented Mar 13, 2026

Uh oh!

FNALbuild commented Mar 13, 2026

Uh oh!

PetrilloAtWork left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

henrylay97 commented Feb 19, 2026 •

edited

Loading