Skip to content

fix(dms): auto-create test repositories for integration tests in dms#162

Merged
NicoleMGomes merged 3 commits into
SAP:mainfrom
I559656:fix/dms-integration-tests
Jun 16, 2026
Merged

fix(dms): auto-create test repositories for integration tests in dms#162
NicoleMGomes merged 3 commits into
SAP:mainfrom
I559656:fix/dms-integration-tests

Conversation

@I559656

@I559656 I559656 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Disclaimer: Do not include SAP-internal or customer-specific information in this PR (e.g. internal system URLs, customer names, tenant IDs, or confidential configurations). This is a public repository.

Description

remove instance_name from BindingData and auto-create test repositories for integration tests in dms.

Related Issue

Closes #<issue_number>

(Link to the GitHub issue this PR addresses)

Type of Change

Please check the relevant option:

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Dependency update

How to Test

Describe how reviewers can test your changes:

  1. Step 1
    run unit test: pytest tests/dms/unit/ -v

  2. Step 2
    run integration test: pytest tests/dms/integration/ -v

  3. Expected result
    all tests should pass

Checklist

Before submitting your PR, please review and check the following:

  • I have read the Contributing Guidelines
  • I have verified that my changes solve the issue
  • I have added/updated automated tests to cover my changes
  • All tests pass locally
  • I have verified that my code follows the Code Guidelines
  • I have updated documentation (if applicable)
  • I have added type hints for all public APIs
  • My code does not contain sensitive information (credentials, tokens, etc.)
  • I have followed Conventional Commits for commit messages

Breaking Changes

If this PR introduces breaking changes, please describe:

  • What breaks
  • Migration path for users
  • Alternative approaches considered

Additional Notes

Add any additional context, screenshots, or information that would help reviewers.

@I559656 I559656 requested a review from a team as a code owner June 15, 2026 17:18
@I559656 I559656 changed the title fix(dms): remove instance_name from BindingData and auto-create test … fix(dms):auto-create test repositories for integration tests in dms Jun 15, 2026
@I559656 I559656 force-pushed the fix/dms-integration-tests branch from 224c018 to 4d256b9 Compare June 15, 2026 17:27
@I559656 I559656 changed the title fix(dms):auto-create test repositories for integration tests in dms fix(dms): auto-create test repositories for integration tests in dms Jun 15, 2026
Comment thread src/sap_cloud_sdk/dms/config.py Outdated
@NicoleMGomes

Copy link
Copy Markdown
Contributor

can you please update INTEGRATION_TESTS.md including dms?

@NicoleMGomes NicoleMGomes merged commit 6e4de9d into SAP:main Jun 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants