Skip to content

fix: adapt event_type to be fetched from descriptop#109

Merged
betinacosta merged 5 commits into
SAP:mainfrom
auditlog-service:auditlog-ng-event-type-fix
Jun 9, 2026
Merged

fix: adapt event_type to be fetched from descriptop#109
betinacosta merged 5 commits into
SAP:mainfrom
auditlog-service:auditlog-ng-event-type-fix

Conversation

@simeongelovski

@simeongelovski simeongelovski commented May 12, 2026

Copy link
Copy Markdown
Member

Updated the auditlog-ng client audit log event name handling to derive the event name directly from the protobuf event descriptor.

Previously, event names were in the format:

sap.als.AuditEvent.<EVENT_TYPE>.v2
With this change, event names now follow the protobuf descriptor naming convention:

sap.auditlog.auditevent.v2.<EVENT_TYPE>
Example:

sap.auditlog.auditevent.v2.ConfigurationChange
This aligns the OTEL event name format with the ALS protobuf schema and the Audit Log SDK implementation, where the event type is resolved from the protobuf DESCRIPTOR.

Breaking Changes

The auditlog-ng client no longer supports user-provided audit event types. Event names are now derived exclusively from the protobuf event descriptor (DESCRIPTOR) and follow the protobuf schema naming convention:

@simeongelovski simeongelovski requested a review from a team as a code owner May 12, 2026 08:05
Comment thread src/sap_cloud_sdk/core/auditlog_ng/client.py
Comment thread src/sap_cloud_sdk/core/auditlog_ng/client.py Outdated
betinacosta
betinacosta previously approved these changes May 18, 2026
@betinacosta betinacosta merged commit e2ad8a4 into SAP:main Jun 9, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants