fix: [openapi-generator-plugin] Resolve Jackson Dependency Convergence #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonas-Isr
approved these changes
Aug 26, 2025
Comment on lines
+62
to
+80
| /** | ||
| * <p> | ||
| * </p> | ||
| * <p> | ||
| * Creates a new pet in the store. Duplicates are allowed | ||
| * </p> | ||
| * <p> | ||
| * <b>200</b> - pet response | ||
| * <p> | ||
| * <b>0</b> - unexpected error | ||
| * | ||
| * @param pet | ||
| * Pet to add to the store | ||
| * @return Pet | ||
| * @throws OpenApiRequestException | ||
| * if an error occurs while attempting to invoke the API | ||
| */ | ||
| @Nonnull | ||
| public Pet addPet( @Nonnull final PetInput pet ) |
Member
There was a problem hiding this comment.
(comment/question)
Are these unnecessary tags expected?
Contributor
Author
There was a problem hiding this comment.
Looks like "summary" is empty string. We could fix this in a separate PR. But very low priority.
This was referenced Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://github.com/SAP/cloud-sdk-java-backlog/issues/488
Related issue
#883
Explicitly define converging dependencies.
Maven will ignore
<dependencyManagement>when resolving plugin dependencies during execution.Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updated