chore: Remove vulnerable commons-configuration
#808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commons-configuration2
newtork
reviewed
May 21, 2025
newtork
reviewed
May 21, 2025
...generator/src/main/java/com/sap/cloud/sdk/datamodel/odata/generator/ODataToVdmGenerator.java
Show resolved
Hide resolved
...nerator/src/main/java/com/sap/cloud/sdk/datamodel/odatav4/generator/ODataToVdmGenerator.java
Outdated
Show resolved
Hide resolved
...nerator/src/main/java/com/sap/cloud/sdk/datamodel/odatav4/generator/ODataToVdmGenerator.java
Outdated
Show resolved
Hide resolved
commons-configuration2commons-configuration
Contributor
Author
CharlesDuboisSAP
left a comment
There was a problem hiding this comment.
Please remove the dependency from the parent pom
| @@ -1,3 +1,4 @@ | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
breaking change?
Contributor
There was a problem hiding this comment.
I do not consider new-line as breaking in context of properties file
Contributor
There was a problem hiding this comment.
However, I've noticed this too.
When I added trim() to the String that was written to file to get rid of the new-line, I got hundreds of file-changes :(
...nerator/src/main/java/com/sap/cloud/sdk/datamodel/odatav4/generator/ODataToVdmGenerator.java
Show resolved
Hide resolved
newtork
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#807
We previously used commons-configuration but the new version is at commons-configuration2
Feature scope:
Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated