feat(openapi-generator): Suppress faulty additionalProperties: true
#689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
commented
Jan 10, 2025
| """; | ||
| final Order order = Order.create().productId(100L).quantity(5).totalPrice(6.0f); | ||
| order.setCustomField("shoesize", 44); | ||
| assertThat(new ObjectMapper().writeValueAsString(order)).isEqualToIgnoringWhitespace(expected); |
Contributor
Author
There was a problem hiding this comment.
(Comment)
Without the enabled feature toggle this test assertion fails:
Expecting actual:
"{}"
to be equal to:
"{
"productId": 100,
"quantity": 5,
"totalPrice": 6.0,
"packaging" : "bottle",
"shoesize": 44
}
MatKuhr
reviewed
Jan 13, 2025
Member
MatKuhr
left a comment
There was a problem hiding this comment.
In case we consider this a fix, a release note would be good. Otherwise LGTM
...i-sample/src/test/java/com/sap/cloud/sdk/datamodel/openapi/sample/api/SerializationTest.java
Show resolved
Hide resolved
...r/src/main/java/com/sap/cloud/sdk/datamodel/openapi/generator/GeneratorCustomProperties.java
Outdated
Show resolved
Hide resolved
additionalProperties: trueadditionalProperties: true
MatKuhr
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://github.tools.sap/AI/ai-sdk-java-backlog/issues/129
additionalProperties: truewill appendextends HashMap<String,Object>to generated class signature. See intermediate commit 7bd61edserialVersionUID. See 7bd61ed#r151192960super#entrySet().However
Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated