Skip to content

Conversation

@CharlesDuboisSAP
Copy link
Contributor

Context

The release script was pointing to the last release when making checks in the perform release. If it did not exist, it still succeeded.

Feature scope:

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

@CharlesDuboisSAP CharlesDuboisSAP added please merge Request to merge a pull request please review Request to review a pull request labels Jan 8, 2025
@CharlesDuboisSAP CharlesDuboisSAP self-assigned this Jan 8, 2025
Copy link
Contributor

@newtork newtork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo

@CharlesDuboisSAP CharlesDuboisSAP merged commit bfab0fa into main Jan 8, 2025
14 checks passed
@CharlesDuboisSAP CharlesDuboisSAP deleted the fix-perform-release branch January 8, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please merge Request to merge a pull request please review Request to review a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants