Skip to content

no redundant venvlauncher targets #6554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 1 commit into from
Dec 28, 2025
Merged

no redundant venvlauncher targets #6554

youknowone merged 1 commit into from
Dec 28, 2025

Conversation

@youknowone
Copy link
Member

@youknowone youknowone commented Dec 27, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Simplified application distribution by removing unnecessary binary variants; only the venvlaunchert executable is now included.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 27, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The change removes three binary targets (venvlauncher, venvwlauncher, venvwlaunchert) from the Cargo.toml manifest, retaining only venvlaunchert. No other configuration sections are affected.

Changes

Cohort / File(s) Summary
Binary target consolidation
crates/venvlauncher/Cargo.toml		 Removed three binary targets: venvlauncher, venvwlauncher, and venvwlaunchert. Retained venvlaunchert as the sole binary target.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • venvlauncher #6527 — Modifies the same crate manifest's binary targets for crates/venvlauncher with overlapping binary names, indicating related refactoring efforts.

Poem

🐰 Three launchers gone, one remains so bright,
venvlaunchert stands alone tonight,
Cargo.toml trimmed with careful grace,
Binaries consolidated—cleaner place! ✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b2ad34 and af3b936.

📒 Files selected for processing (1)
  • crates/venvlauncher/Cargo.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone marked this pull request as ready for review December 28, 2025 00:08
@youknowone youknowone merged commit fd6c548 into RustPython:main Dec 28, 2025
12 of 13 checks passed
@youknowone youknowone deleted the venvlauncher branch December 28, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@youknowone