Update Sre Engine Implementing to CPython 3.12 #5125
Conversation
|
@qingshi163 can |
sure |
vm/Cargo.toml
Outdated
| # sre-engine = "0.4.1" | ||
| # to work on sre-engine locally or git version | ||
| # sre-engine = { git = "https://github.com/RustPython/sre-engine", rev = "refs/pull/14/head" } | ||
| sre-engine = { git = "https://github.com/RustPython/sre-engine", rev = "refs/pull/17/head" } |
There was a problem hiding this comment.
I am sorry to forget about this. update to recent release of sre-engine or import the source code here?
There was a problem hiding this comment.
Can you move the repr to rustpython-sre-engine.
|
@qingshi163 other clippy errors looks mostly false positive or trivial. But could you check if |
The loop of valued break is needed for performance issue, we just need to ignore the warning |
template_compile template_expand subx
youknowone
left a comment
There was a problem hiding this comment.
Let's remove unused code blocks or add a TODO note to share why they are left as commented.
|
Please revert the deletion once it is required |
RustPython/sre-engine#17