Move isSequential and isUpdating from RuntimeIterator to RuntimeStaticContext#1727
Open
CaiJimmy wants to merge 27 commits into
Open
Move isSequential and isUpdating from RuntimeIterator to RuntimeStaticContext#1727CaiJimmy wants to merge 27 commits into
isSequential and isUpdating from RuntimeIterator to RuntimeStaticContext#1727CaiJimmy wants to merge 27 commits into
Conversation
…ate RuntimeIterator to use them
…pdate RuntimeIteratorVisitor to use builder pattern for static context
…constructor to use List for children
… streamline constructor with Stream API
…ern for static context and remove redundant isUpdating and isSequential fields
…d isUpdating checks
…se staticContext for isUpdating checks
…n static context builder
…t with isUpdating flag
…lize isSequential and isUpdating flags in static context
…tilize static context builder for isSequential flag
…utilize static context builder for isSequential flag
… isSequential flag
…r isSequential flag
…tic context builder for isUpdating flag
…ithExprIterator constructor
QT3 Test Results - Parser:
|
| Test Suite | Passing | Failing | Errors | Skipped | Total |
|---|---|---|---|---|---|
app |
1927 | 53 | 162 | 15 | 2157 |
array |
207 | 0 | 1 | 1 | 209 |
fn |
9227 | 590 | 684 | 634 | 11135 |
map |
220 | 0 | 0 | 0 | 220 |
math |
149 | 0 | 0 | 0 | 149 |
misc |
686 | 85 | 31 | 69 | 871 |
op |
4106 | 83 | 105 | 72 | 4366 |
prod |
9700 | 614 | 465 | 1428 | 12207 |
ser |
321 | 21 | 1 | 0 | 343 |
xs |
147 | 2 | 0 | 15 | 164 |
| Total | 26690 | 1448 | 1449 | 2234 | 31821 |
Full analysis report: see analysis-jsoniq in artifacts.
QT3 Test Results - Parser:
|
| Test Suite | Passing | Failing | Errors | Skipped | Total |
|---|---|---|---|---|---|
app |
1966 | 52 | 132 | 7 | 2157 |
array |
207 | 0 | 1 | 1 | 209 |
fn |
9281 | 563 | 685 | 606 | 11135 |
map |
220 | 0 | 0 | 0 | 220 |
math |
149 | 0 | 0 | 0 | 149 |
misc |
706 | 78 | 27 | 60 | 871 |
op |
4229 | 34 | 62 | 41 | 4366 |
prod |
10438 | 509 | 414 | 846 | 12207 |
ser |
343 | 0 | 0 | 0 | 343 |
xs |
149 | 0 | 0 | 15 | 164 |
| Total | 27688 | 1236 | 1321 | 1576 | 31821 |
Full analysis report: see analysis-xquery in artifacts.
CaiJimmy
marked this pull request as ready for review
July 23, 2026 16:44
… improved context handling
CaiJimmy
commented
Jul 23, 2026
Comment on lines
+335
to
+336
| expression.getStaticContextForRuntime(this.config, this.visitorConfig) | ||
| .toBuilder() |
Collaborator
Author
There was a problem hiding this comment.
We don't have staticType assignation here because it's already done by getStaticContextForRuntime
CaiJimmy
commented
Jul 23, 2026
| .executionMode(returnClause.getHighestExecutionMode(this.visitorConfig)) | ||
| .metadata(returnClause.getMetadata()) | ||
| .build() | ||
| statement.getStaticContextForRuntime(this.config, this.visitorConfig) |
Collaborator
Author
There was a problem hiding this comment.
Same here, all those assignation done by getStaticContextForRuntime
CaiJimmy
commented
Jul 23, 2026
| elseBranch | ||
| ), | ||
| staticContext | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
This change overlaps with #1729, I will first merge that one so the changeset is more clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: during the refactor, I found some potential inconsistencies in isSequential and isUpdate assignation. I think I fixed them.