Skip to content

Move isSequential and isUpdating from RuntimeIterator to RuntimeStaticContext#1727

Open
CaiJimmy wants to merge 27 commits into
masterfrom
jimmy/move-issequential-isupdating
Open

Move isSequential and isUpdating from RuntimeIterator to RuntimeStaticContext#1727
CaiJimmy wants to merge 27 commits into
masterfrom
jimmy/move-issequential-isupdating

Conversation

@CaiJimmy

@CaiJimmy CaiJimmy commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Note: during the refactor, I found some potential inconsistencies in isSequential and isUpdate assignation. I think I fixed them.

CaiJimmy added 23 commits July 23, 2026 14:40
…pdate RuntimeIteratorVisitor to use builder pattern for static context
…ern for static context and remove redundant isUpdating and isSequential fields
…lize isSequential and isUpdating flags in static context
…tilize static context builder for isSequential flag
…utilize static context builder for isSequential flag
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

QT3 Test Results - Parser: jsoniq

Regression baseline: run 30014616686

🎉 No regressions found for this build.

Summary of passed tests for jsoniq
Test Suite Passing Failing Errors Skipped Total
app 1927 53 162 15 2157
array 207 0 1 1 209
fn 9227 590 684 634 11135
map 220 0 0 0 220
math 149 0 0 0 149
misc 686 85 31 69 871
op 4106 83 105 72 4366
prod 9700 614 465 1428 12207
ser 321 21 1 0 343
xs 147 2 0 15 164
Total 26690 1448 1449 2234 31821

Full analysis report: see analysis-jsoniq in artifacts.

Download detailed test results

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

QT3 Test Results - Parser: xquery

Regression baseline: run 30014616686

🎉 No regressions found for this build.

Summary of passed tests for xquery
Test Suite Passing Failing Errors Skipped Total
app 1966 52 132 7 2157
array 207 0 1 1 209
fn 9281 563 685 606 11135
map 220 0 0 0 220
math 149 0 0 0 149
misc 706 78 27 60 871
op 4229 34 62 41 4366
prod 10438 509 414 846 12207
ser 343 0 0 0 343
xs 149 0 0 15 164
Total 27688 1236 1321 1576 31821

Full analysis report: see analysis-xquery in artifacts.

Download detailed test results

@CaiJimmy
CaiJimmy marked this pull request as ready for review July 23, 2026 16:44
@CaiJimmy
CaiJimmy requested a review from ghislainfourny as a code owner July 23, 2026 16:44
Comment on lines +335 to +336
expression.getStaticContextForRuntime(this.config, this.visitorConfig)
.toBuilder()

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have staticType assignation here because it's already done by getStaticContextForRuntime

.executionMode(returnClause.getHighestExecutionMode(this.visitorConfig))
.metadata(returnClause.getMetadata())
.build()
statement.getStaticContextForRuntime(this.config, this.visitorConfig)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, all those assignation done by getStaticContextForRuntime

elseBranch
),
staticContext
);

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change overlaps with #1729, I will first merge that one so the changeset is more clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant