Skip to content

Fix TaskDispatcher not catching exception #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunnamed434 merged 2 commits into from
Jul 4, 2024
Merged

Fix TaskDispatcher not catching exception #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bce93bb
Fix TaskDispatcher not catching exception
sunnamed434 Jun 27, 2024
cd6b32a
Merge branch 'master' into fix/87
sunnamed434 Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions Rocket/Rocket.Core/Utils/RocketDispatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,14 @@ private void FixedUpdate()
}
foreach (var a in currentActions)
{
a();
try
{
a();
}
catch (Exception ex)
{
Logging.Logger.LogException(ex, "An error occured while executing action");
}
}

List<DelayedQueueItem> currentDelayed = new List<DelayedQueueItem>();
Expand All @@ -100,7 +107,14 @@ private void FixedUpdate()
}
foreach (DelayedQueueItem item in currentDelayed)
{
item.action();
try
{
item.action();
}
catch (Exception ex)
{
Logging.Logger.LogException(ex, "An error occured while executing delayed action");
}
}

}
Expand Down