Skip to content

Break project to a workspace with two sub crates#996

Merged
gkorland merged 14 commits intomasterfrom
gkorland-jsonpath-sub
May 12, 2023
Merged

Break project to a workspace with two sub crates#996
gkorland merged 14 commits intomasterfrom
gkorland-jsonpath-sub

Conversation

@gkorland
Copy link
Contributor

No description provided.

@gkorland gkorland changed the title break json_path to sub crate Break project to a workspace with two sub crates May 11, 2023
gkorland and others added 3 commits May 11, 2023 16:38
Co-authored-by: Guy Korland <gkorland@gmail.com>
@gkorland gkorland marked this pull request as ready for review May 11, 2023 13:59
iddm
iddm previously approved these changes May 11, 2023
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 94.46% and project coverage change: +0.98 🎉

Comparison is base (7361ad4) 81.45% compared to head (3f87268) 82.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #996      +/-   ##
==========================================
+ Coverage   81.45%   82.44%   +0.98%     
==========================================
  Files          15       16       +1     
  Lines        3894     4032     +138     
==========================================
+ Hits         3172     3324     +152     
+ Misses        722      708      -14     
Impacted Files Coverage Δ
json_path/src/json_node.rs 78.88% <ø> (ø)
json_path/src/lib.rs 81.81% <ø> (ø)
json_path/src/select_value.rs 100.00% <ø> (ø)
redis_json/src/array_index.rs 100.00% <ø> (ø)
redis_json/src/backward.rs 86.04% <ø> (ø)
redis_json/src/c_api.rs 8.60% <0.00%> (ø)
redis_json/src/error.rs 52.94% <ø> (ø)
redis_json/src/formatter.rs 100.00% <ø> (ø)
redis_json/src/lib.rs 86.53% <ø> (ø)
redis_json/src/manager.rs 50.00% <ø> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gkorland gkorland merged commit 8ca4043 into master May 12, 2023
@gkorland gkorland deleted the gkorland-jsonpath-sub branch May 12, 2023 16:01
@oshadmi
Copy link
Collaborator

oshadmi commented May 12, 2023

@gkorland I suppose RedisJsonHdt needs to adjust accordingly?

@gkorland
Copy link
Contributor Author

not sure... does it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants