Skip to content

MOD-4822: Disable recursion limit on RDB load#919

Merged
gkorland merged 6 commits intomasterfrom
gkorland-recursion-limit
Jan 30, 2023
Merged

MOD-4822: Disable recursion limit on RDB load#919
gkorland merged 6 commits intomasterfrom
gkorland-recursion-limit

Conversation

@gkorland
Copy link
Contributor

No description provided.

Copy link

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test?
We will need to do it for hdt as well.

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Base: 81.36% // Head: 81.40% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (15be482) compared to base (54125ef).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 15be482 differs from pull request most recent head 1ee762b. Consider uploading reports for the commit 1ee762b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
+ Coverage   81.36%   81.40%   +0.04%     
==========================================
  Files          15       15              
  Lines        3896     3905       +9     
==========================================
+ Hits         3170     3179       +9     
  Misses        726      726              
Impacted Files Coverage Δ
src/manager.rs 57.14% <ø> (ø)
src/commands.rs 95.67% <100.00%> (ø)
src/ivalue_manager.rs 90.12% <100.00%> (+0.10%) ⬆️
src/redisjson.rs 82.55% <100.00%> (ø)
src/serde_value_manager.rs 89.45% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gkorland gkorland changed the title Disable recursion limit on RDB load MOD-4822: Disable recursion limit on RDB load Jan 29, 2023
# RDB dump and restore the key 'doc' and check that the key is still valid
dump = env.execute_command('dump', 'doc', **{NEVER_DECODE: []})
r.expect('RESTORE', 'doc1', 0, dump).ok()
r.expect('JSON.GET', 'doc1', '$..z..z').equal('["a"]')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also check debug reload?

MeirShpilraien
MeirShpilraien previously approved these changes Jan 29, 2023
Copy link

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gkorland gkorland merged commit 5f701d0 into master Jan 30, 2023
@gkorland gkorland deleted the gkorland-recursion-limit branch January 30, 2023 08:29
rafie pushed a commit that referenced this pull request Jan 31, 2023
* disable recursion limit on RDB load

(cherry picked from commit 5f701d0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants