Update webpage md to create tabbed examples#1088
Open
sav-norem wants to merge 7 commits intoRedisJSON:masterfrom
Open
Update webpage md to create tabbed examples#1088sav-norem wants to merge 7 commits intoRedisJSON:masterfrom
sav-norem wants to merge 7 commits intoRedisJSON:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1088 +/- ##
=======================================
Coverage 78.02% 78.02%
=======================================
Files 15 15
Lines 3891 3891
=======================================
Hits 3036 3036
Misses 855 855 ☔ View full report in Codecov by Sentry. |
dwdougherty
suggested changes
Sep 15, 2023
Co-authored-by: David Dougherty <david.dougherty@redis.com>
dwdougherty
suggested changes
Nov 15, 2023
Contributor
dwdougherty
left a comment
There was a problem hiding this comment.
Please fix the closing example tags in _index.md. I will then do another test build.
Author
|
@dwdougherty fixed Hugo short codes |
dwdougherty
approved these changes
Nov 15, 2023
Contributor
dwdougherty
left a comment
There was a problem hiding this comment.
LGTM. Builds correctly.
oshadmi
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to have tabbed client language examples on every data type page on redis.io, we need to include Hugo short codes and update the CLI examples