MOD-5606: Rename FORMAT args and change defaults#1056
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1056 +/- ##
==========================================
+ Coverage 78.97% 79.09% +0.12%
==========================================
Files 15 15
Lines 3820 3842 +22
==========================================
+ Hits 3017 3039 +22
Misses 803 803
☔ View full report in Codecov by Sentry. |
Comment on lines
+121
to
+125
| let next = args.next_str()?; | ||
| if next.eq_ignore_ascii_case("STRINGS") { | ||
| return Err(RedisError::Str("ERR wrong reply format")); | ||
| } | ||
| format_options.format = ReplyFormat::from_str(next)?; |
There was a problem hiding this comment.
Why not comparing the format and avoid another string comparison ?
| if next.eq_ignore_ascii_case("STRING") { | ||
| return Err(RedisError::Str("ERR wrong reply format")); | ||
| } | ||
| format_options.format = ReplyFormat::from_str(next)?; |
MeirShpilraien
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON.GETRename
JSONtoEXPAND1Default is
STRINGJSON.ARRPOPRename
STRINGtoSTRINGSRename
JSONtoEXPAND1Default is
STRINGSFollowup PR:
Support FORMAT
STRINGSinJSON.GETto return an array of arrays of STRING(as with
JSON.ARRPOP)