1.x: fix: bounded replay() not requesting enough for latecommers#3454
Merged
akarnokd merged 1 commit intoReactiveX:1.xfrom Dec 14, 2015
Merged
1.x: fix: bounded replay() not requesting enough for latecommers#3454akarnokd merged 1 commit intoReactiveX:1.xfrom
akarnokd merged 1 commit intoReactiveX:1.xfrom
Conversation
This was referenced Oct 16, 2015
Member
|
Don't have the time to fully grok this, but the changes look okay and I trust @akarnokd on this. So 👍 |
Member
Author
|
Thank you @benjchristensen. Since |
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Dec 14, 2015
1.x: fix: bounded replay() not requesting enough for latecommers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug reported in #3452.
The fix involves 3 changes:
manageRequests()at this point.In addition, there was a missing
r--in the emission loop and thus the operator could have overflown its child subscriber.