Allow parenthesis and backslash characters inside default values #977
Conversation
Now we can use parenthesis characters inside quoted strings for default values, without disturbing the arguments parser.
|
Thanks for the PR -- we will take a good look. I was about to roll up 1.0.2 but this may still fit in. |
|
This change looks correct to me. @kevinushey Could you also take a look? |
src/attributes.cpp
Outdated
| case ')': | ||
| parenCount--; // #nocov | ||
| break; // #nocov | ||
| endOfArg = true; |
There was a problem hiding this comment.
This looks correct to me but IMHO the endOfArg flag is a bit more confusing than just using continue to bypass adding characters to the current argument. Is there a reason why you made that switch (perhaps I'm missing a nuance)? Or just style?
There was a problem hiding this comment.
Hi, I used it when the escape character was still handled with a char prevChar variable that was set at the end of the loop. So for consistency, I preferred to replace the continue with endOfArg in order for prevChar to be set even when a comma was met (it was not the case with the continue statement, prevChar was not updated).
Since I've now changed prevChar with the boolean variable escaped and escaped is set before testing for a comma that marks the end of an argument, we can go back to the continue statement. I will make the change.
There was a problem hiding this comment.
Thanks for pointing this you, by the way.
Solves #975
The argument parser method
SourceFileAttributesParser::parseArguments()has been modified in order to allow the use of parenthesis and backslash characters inside quoted strings and character values.