Add DateVector and DatetimeVector default ctors (closes #1384) #1385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds default constructors for DateVector and DatetimeVector to align the Rcpp API with typical R conventions.
- Added default constructors in newDateVector.h and newDatetimeVector.h
- Added corresponding tests in inst/tinytest/test_date.R and inst/tinytest/cpp/dates.cpp
- Updated copyright years to reflect the current year
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| inst/tinytest/test_date.R | Added tests to validate that the default constructors create empty vectors with correct class types |
| inst/tinytest/cpp/dates.cpp | Added exportable functions for default DateVector and DatetimeVector creation |
| inst/include/Rcpp/date_datetime/newDatetimeVector.h | Added a default constructor that sets the class using the provided timezone |
| inst/include/Rcpp/date_datetime/newDateVector.h | Added a default constructor that sets the class |
| ChangeLog | Documented the new default constructors and corresponding tests |
Enchufa2
approved these changes
May 26, 2025
Member
Enchufa2
left a comment
There was a problem hiding this comment.
Small and focused, as you said. No further comments.
Member
Author
|
Thanks! I will summarise the reverse depends run in a bit. It may be that we tickle a change here or there in which case we could table this for the release after the next (which is coming up in five weeks) (or could try to cram it in, to be seen). |
Member
Author
|
Reverse-depends worked out as well:
With that we're good so ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1384 these were omitted in earlier implementations, mostly due to sloppy thinking and a bias towards the data(time) in
std::vectoruse seen in another library that was interfaced at the very (very !!) beginning of Rcpp. But that is simply not the R way of things, and while we did on pass over this (when the thennewDate*Vectorclasses were added we still did not add empty constructors. Which I now use more often for base types (thinkinteger()etc) so we should have something like that here too.The PR itself is pretty minimal and just adds these new ctors, does not alter existing interfaces, and adds a handful of test predicates.
A complete reverse-dependency check is running but it will (as usual) be a good moment before it is done.
Checklist
R CMD checkstill passes all tests