Address clang conversion warnings #1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Thank you both! |
Member
Author
|
I will need a one-line follow-up as the change in ccache g++ -I"/usr/share/R/include" -DNDEBUG -I../inst/include/ -fpic -g -O2 -Wall -pipe -pedantic -c attributes.cpp -o attributes.o
attributes.cpp: In member function ‘std::string Rcpp::attributes::SourceFileAttributesParser::parseSignature(size_t)’:
attributes.cpp:1624:38: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘R_xlen_t’ {aka ‘long int’} [-Wsign-compare]
1624 | for (size_t i = lineNumber; i<lines_.size(); i++) {
| ~^~~~~~~~~~~~~~
ccache g++ -I"/usr/share/R/include" -DNDEBUG -I../inst/include/ -fpic -g -O2 -Wall -pipe -pedantic -c barrier.cpp -o barrier.o |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses warnings seen when building with
clang++-14 -Wall -pedantic -Wconversion -Wno-sign-conversionas done on the CRAN 'M1mac' box. It is a fairly simple set of casts. It seems to make sense to fold this into the pending 1.0.10 even though we otherwise dislike making very last minute changes...Checklist
R CMD checkstill passes all tests