define safe variant of short_file_name #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think we once use proper deprecation. We could "tag" the older unsafer variant and say it'll go in, say, 12 month. Thoughts? (That is somewhat orthogonal to the PR though of course not fully...) |
eddelbuettel
approved these changes
Apr 10, 2020
Contributor
Author
|
I don't have any strong feelings re: deprecation -- I'll let you make the call. I expect removing it would go smoothly, but experience has taught me to always expect surprises. |
Codecov Report
@@ Coverage Diff @@
## master #1067 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 64 64
Lines 2782 2782
=======================================
Hits 2660 2660
Misses 122 122
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template for Rcpp
Closes #1066. This PR comes with two pieces:
A "safe" definition of
short_file_name, defined and used explicitly in theRcpp::debugnamespace;A re-worked version of the "old" (+ registered)
short_file_name, which now uses a static buffer. I believe the method should be effectively un-used but I figured since it's a registered routine it's best to keep the API the same and just silence the compiler warning.Checklist
R CMD checkstill passes all tests