Skip to content

Fix Rcpp_list2 issue (closes #1053) #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eddelbuettel merged 2 commits into from
Mar 19, 2020
Merged

Fix Rcpp_list2 issue (closes #1053) #1054

eddelbuettel merged 2 commits into from
Mar 19, 2020

Conversation

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Mar 18, 2020

This adds definitions for Rcpp_list2() to Rcpp_list5(). At least one BioConductor package explicitly referenced Rcpp::Rcpp_list2() and we broke that in 1.0.4.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

@eddelbuettel eddelbuettel requested a review from kevinushey March 18, 2020 14:22
@codecov-io
Copy link

codecov-io commented Mar 18, 2020

Codecov Report

Merging #1054 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1054   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files          64       64           
  Lines        2778     2778           
=======================================
  Hits         2656     2656           
  Misses        122      122

@eddelbuettel
Copy link
Member Author

eddelbuettel commented Mar 19, 2020 •
edited
Loading

Reverse depends check moving on along with just the usual handful of issues. Copy and
paste from the output of the summariseJobs.r script in pprd:

Test of Rcpp had 1099 successes, 4 failures, and 35 skipped packages.
Ran from 2020-03-18 09:36:41.55 to 2020-03-18 21:48:59.10 for 12.205 hours
Average of 38.609 secs relative to 228.952 secs using 6 runners

Failed packages:  bigsnpr, gtfs2gps, lavaSearch2, mfbvar

Skipped packages:  BayesianTools, bgsmtr, brms, cld2, DataVisualizations, dipsaus, \
  dynamichazard, estimatr, EstMix, EWGoF, gkmSVM, gpuR, growfunctions, hBayesDM,\
  IMaGES, joineRML, joinXL, KeyboardSimulator, kmcudaR, LANDD, lime, lme4, mafs, \
  Mega2R, metacoder, mice, miceadds, Morpho, mrgsolve, nlmixr, NLMR, odpc,  \
  partialAR, pcalg, pccc

     id              title                  message  status requeued
1: 1114       pcFactorStan       pcFactorStan_1.4.0 WORKING        0
2: 1138           phangorn           phangorn_2.5.5 WORKING        0
3: 1139            phantom            phantom_0.1.3 WORKING        0
4: 1142           phenofit         phenofit_0.2.5-2 WORKING        0
5: 1143 PhenotypeSimulator PhenotypeSimulator_0.3.3 WORKING        0
6: 1144        philentropy        philentropy_0.4.0 WORKING        0

       id          title              message status requeued
  1: 1145        phonics        phonics_1.3.2  READY        0
  2: 1146       phybreak       phybreak_0.2.0  READY        0
  3: 1147      phylobase     phylobase_0.8.10  READY        0
  4: 1148     phylocurve    phylocurve_2.0.10  READY        0
  5: 1149 PhylogeneticEM PhylogeneticEM_1.4.0  READY        0
 ---
726: 1870           YPPE           YPPE_1.0.1  READY        0
727: 1871          yuima          yuima_1.9.6  READY        0
728: 1872            zic            zic_0.9.1  READY        0
729: 1873        ziphsmm        ziphsmm_2.0.6  READY        0
730: 1874           ZVCV           ZVCV_1.0.0  READY        0

About 730 more to go.

@eddelbuettel
Copy link
Member Author

eddelbuettel commented Mar 19, 2020 •
edited
Loading

The reverse depends check proceeded fine with no new issues, see here for summary.

@kevinushey as you find time, a review would be appreciated. Else I can always push. Nobody from Vienna or elsewhere breathing down our necks....

@kevinushey
Copy link
Contributor

kevinushey commented Mar 19, 2020

LGTM!

@eddelbuettel eddelbuettel merged commit 5ea44f1 into master Mar 19, 2020
@eddelbuettel eddelbuettel deleted the bugfix/rf_list2 branch March 19, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinushey kevinushey Awaiting requested review from kevinushey

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eddelbuettel @codecov-io @kevinushey