persistent controls in python_example bot#5
Merged
tarehart merged 1 commit intoRLBot:masterfrom Jun 20, 2018
Merged
Conversation
Contributor
Author
|
Currently untested since I'm at work. I'll test when I get home and comment when done. |
dtracers
approved these changes
Jun 19, 2018
Contributor
Author
|
I've tested it, works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the controller_state initialization to the initialize_agent method and make it an object property, so that control settings persist until they are changed, rather than needing to be set every tick. This should be more intuitive for new users.