Conversation
Update 1/4
Contributor
|
is |
Author
|
You're right. That's just an issue with the way I created the PR. I'll go fix that quickly |
Fixing a naming issue
Author
|
That should be good for now. I might steal Marvin's code if it turns out that using LUTs is a super bad idea. That said, there is an advantage to being able to do a look up and have your boost used, distance traveled, final velocity, and time taken calculated afterwards. |
tarehart
approved these changes
Feb 15, 2020
Contributor
tarehart
left a comment
There was a problem hiding this comment.
Looks good! I might snip out some of those enums which look unused. We might move to a non-LUT solution at some point, but this looks very effective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 1D Kinematic driving simulations using look up tables. Also add some constants so people don't have to keep going to the wiki for common values.