feat(graphql): refactor service#851
Merged
Merged
Conversation
added 3 commits
June 2, 2026 19:51
stdevi
commented
Jun 2, 2026
stdevi
commented
Jun 2, 2026
stdevi
commented
Jun 2, 2026
stdevi
commented
Jun 2, 2026
stdevi
commented
Jun 2, 2026
stdevi
commented
Jun 2, 2026
raluik
requested changes
Jun 3, 2026
Contributor
There was a problem hiding this comment.
Awesome! 1 issue worth looking into.
- issue: dashboard doesn't receive connection loss status anymore:
Screen.Recording.2026-06-03.at.15.13.36.mov
Notes:
Use qminder bind-javascript-api and then yarn build in javascript-api to see javascript-api changes.
|
|
||
| private handleBrowserOnline(): void { | ||
| if (this.offlineSince === null) { | ||
| this.logger.warn('Browser came back online'); |
Contributor
There was a problem hiding this comment.
suggestion(non-blocking): should it be a warn, not info? Same here.
suggestion(non-blocking): maybe Browser came online as back would indicate that it dropped unexpectedly?
Comment on lines
+90
to
+92
| service.handleBrowserOffline(); | ||
| jest.advanceTimersByTime(5000); | ||
| service.handleBrowserOnline(); |
Contributor
There was a problem hiding this comment.
polish: could do window.dispatchEvent(new Event('offline')) and ... Already do in other JSDOM spec file.
|
|
||
| await jest.runOnlyPendingTimersAsync(); | ||
|
|
||
| expect(backoffSpy).toHaveBeenCalled(); |
Contributor
There was a problem hiding this comment.
suggestion(non-blocking): maybe toHaveBeenCalledTimes(1)?
added 10 commits
June 3, 2026 12:55
raluik
reviewed
Jun 4, 2026
raluik
approved these changes
Jun 4, 2026
raluik
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.