feat: migrate ticket editing endpoint to V2 API#824
Merged
Conversation
Update TicketService.edit() from V1 (POST /v1/tickets/{id}/edit,
form-encoded) to V2 (PATCH /tickets/{id}, JSON body with
X-Qminder-API-Version header).
Changes:
- ApiBase: preserve PATCH method with body, handle empty response bodies
- edit(): use PATCH + JSON body + version header, return void
- TicketEditingParameters: remove extra/user, add languageCode, allow null
Add descriptive error message when response body is not valid JSON instead of exposing a raw SyntaxError. Reject empty changes object in ticket edit to prevent sending a no-op PATCH request.
raluik
requested changes
Mar 13, 2026
raluik
reviewed
Mar 13, 2026
- Replace `any` with generic type `T` for parsedResponse in api-base - Remove unnecessary truthiness check on response.text() result - Remove response body truncation in JSON parse error message - Make languageCode non-nullable in TicketEditingParameters - Update test descriptions for clarity
…ing review feedback - Restore empty body handling for successful responses (V2 PATCH returns empty body) - Remove redundant optional chaining inside options?.body guard - Replace any with TicketEditingParameters in test fixture - Revert languageCode JSDoc parenthetical per reviewer request
raluik
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TicketService.edit()from V1 (POST /v1/tickets/{id}/edit, form-encoded) to V2 (PATCH /tickets/{id}, JSON body withX-Qminder-API-Version: 2020-09-01header)ApiBase.request()to preserve PATCH method with body and handle empty response bodiesTicketEditingParameters: removeextra/user, addlanguageCode, allownullto clear fieldsTest plan