Make compatible with wxPython 3.0#94
Conversation
|
Awesome! Can you explicitly confirm that you agree to have your code licensed under the MIT license? Feel free to create an AUTHORS file with our names and add it to the PR. |
|
Sure, I agree to my code being licensed under MIT. Please make sure the application still runs for you. I have not tested the changes under Windows and older versions of Ubuntu. |
|
Ah sorry, I don't want to spend the time testing that. I'm not so
interested in PythonTurtle. If you're moderately sure that it won't break
Windows then that's good enough for me. Let me know.
…On Sat, Dec 17, 2016 at 9:51 PM, Peter Bittner ***@***.***> wrote:
Sure, I agree to my code being licensed under MIT.
Please make sure the application still runs for you. I have not tested the
changes under Windows and older versions of Ubuntu.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#94 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADdypSAevCH4F-Zu-DhWeS9jdcqY4hcks5rJD0mgaJpZM4LP7yd>
.
|
|
I'm moderately sure the changes will retain the current behavior, hence not affect Windows. But you never know until you prove it. Will you package a new version for download from the website? |
|
I accepted the MR, but I won't create a package, sorry. I don't want to spend time doing that. (I've written PythonTurtle like 7 years ago and have little interest in it now.) If you create a package I'll be happy to post it on the website. If this project is to continue, what's really needed is to automate the process of creating installers for Windows and Mac, so if you or anyone else wishes to contribute, that'll be the best area to do so. |
This PR adds compatibility code for running PythonTurtle on Ubuntu 16.04.1 Xenial with
python-wxgtk3.0and Python 2.7.12.References