Open
Conversation
-added functionality to load multiple functions from file -refactored command formatting, extracted a method
bittner
requested changes
Feb 7, 2020
Member
bittner
left a comment
There was a problem hiding this comment.
That's a wonderful idea, great! 👍
- Can you please fix the code style issues? You may want to run
flake8andpylint, or simplytoxlocally before you push your changes. - I'm not convinced whether a newly invented file extension makes sense. Let's stick to
*.pyand handle unusable files gracefully. In the end, also in*.ptffiles you may have invalid code or unknown functions.
Member
|
Hey, this looks good. I'll take a look at it tomorrow. |
Member
|
Hey, I looked at it now. Lots of problems. Thanks @Mustang01 for working on this often-requested feature. Do fix the code style issues. For example use underscore naming when possible (i.e. I'll try playing around with this feature after you've fixed the issues above. |
Member
|
@Mustang01 Do you have time to fix the issues we addressed? That would allow us to merge your changes. Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds "Open..." to the file menu, allowing the user to open a file that has python function definitions (only). Includes new help screen to explain how this is used.
Related issues: #64