FOUR-20540 Validation and Documentation-part 1#7801
Closed
gproly wants to merge 31 commits into
Closed
Conversation
…ker into observation/FOUR-21120
FOUR-21117: Platform labels are not showing in the list of strings for translation.
After synchronization all languages are displayed in English
bugfix/FOUR-21142: New Password Input disappears in password/change page with users
observation/FOUR-21138 devLink > Server error message is displayed when a Collection is downloaded
FOUR-21130: The users needs to have per default the permissions "View My Request"
FOUR-21104 : Mobile > Tabs do not have the correct style
Build #3f3a06cd
Update translations for changed strings
Build #fe0627fe
nolanpro
requested changes
Dec 6, 2024
nolanpro
left a comment
Contributor
There was a problem hiding this comment.
- We don't need the "Using PromPHP/prometheus_client_php in Laravel with a Facade" section. Please remove it. Instead, please give some examples how developers can use the Metrics facade from here: #7772
- I think it still needs to be easier for developers to view Grafana. Create a folder in core called metrics and use Docker Compose. Use this as an example: https://github.com/docker/awesome-compose/tree/master/prometheus-grafana
The developer should only need to cd metrics and docker compose up then visit http://localhost:3000 to see Grafana
|
Contributor
Author
These changes will be introduced in the feature/FOUR-20535 branch due to a dependency on changes. Therefore, this branch and the pull request are being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation and Documentation-part 1
Validate Metrics Setup:
Create Documentation:
Related Tickets & Packages
https://processmaker.atlassian.net/browse/FOUR-20540