Skip to content

Wrap task scheduler manager in schedule call method#2883

Merged
velkymx merged 2 commits into
developfrom
bugfix/2882
Feb 20, 2020
Merged

Wrap task scheduler manager in schedule call method#2883
velkymx merged 2 commits into
developfrom
bugfix/2882

Conversation

@nolanpro

@nolanpro nolanpro commented Feb 19, 2020

Copy link
Copy Markdown
Contributor

Fixes #2882

  • Wrap the task manager in schedule->call so it has access to the full bootstrapped app environment
  • Remove unused $schedule argument for scheduleTasks method

velkymx
velkymx approved these changes Feb 20, 2020
View reviewed changes

@velkymx velkymx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the quick fix

@velkymx velkymx merged commit 449746a into develop Feb 20, 2020
@velkymx velkymx deleted the bugfix/2882 branch August 10, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@velkymx velkymx velkymx approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scheduled tasks do not have access to routes

2 participants

@nolanpro @velkymx