Normalize white-space and odd digit counts in hexadecimal strings#452
Merged
Conversation
PrinsFrank
requested changes
Jul 20, 2026
PrinsFrank
left a comment
Owner
There was a problem hiding this comment.
Hi, thanks for the PR!
Can you please rebase this? I'm willing to do it but am unable to do so because the "allow edits by maintainer" checkbox is not checked.
Can you also clean up the comments?
Thanks again!
Per 7.3.4.3, white-space within a hexadecimal string is ignored and a missing final digit is assumed to be 0. Such spec-valid strings were passed straight to hex2bin(), which emitted a warning and returned false, so the string was rejected and its text lost.
Contributor
Author
|
rebased, inline comments removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per 7.3.4.3, white-space within a hexadecimal string is ignored and a missing final digit is assumed to be 0. Such spec-valid strings were passed straight to hex2bin(), which emitted a warning and returned false, so the string was rejected and its text lost.