docs(contributing): add link check information#8659
Merged
TravisEz13 merged 12 commits intoPowerShell:masterfrom Jan 16, 2019
RDIL:patch-2
Merged
docs(contributing): add link check information#8659TravisEz13 merged 12 commits intoPowerShell:masterfrom RDIL:patch-2
TravisEz13 merged 12 commits intoPowerShell:masterfrom
RDIL:patch-2
Conversation
adityapatwardhan
requested changes
Jan 16, 2019
Co-Authored-By: RDIL <jumbocakefdx@gmail.com>
Contributor
Author
|
@adityapatwardhan feedback addressed, @TravisEz13 ready for review. |
alexandair
reviewed
Jan 16, 2019
alexandair
reviewed
Jan 16, 2019
Contributor
Author
|
@adityapatwardhan please re-review since requested changes were addressed. |
adityapatwardhan
approved these changes
Jan 16, 2019
TravisEz13
reviewed
Jan 16, 2019
TravisEz13
reviewed
Jan 16, 2019
| * if the `.spelling` file is updated, commit and push it | ||
|
|
||
| #### Checking links in documentation | ||
| Documentation is link-checked. We make use of the |
Member
There was a problem hiding this comment.
I would suggest saying that this and markdown syntax checking (like the newline before and after headers.) can be checked by running start-pspester -includecommontests
TravisEz13
reviewed
Jan 16, 2019
TravisEz13
reviewed
Jan 16, 2019
| #### Spellchecking documentation | ||
|
|
||
| Documentation are spellchecked. We make use of the | ||
| Documentation is spellchecked. We use the |
Member
There was a problem hiding this comment.
This file apparently isn't being checked for markdown syntax issues.
You can add it by updating this list
PowerShell/test/common/markdown/markdown.tests.ps1
Lines 57 to 67 in 03cd3a2
Not a requirement. If you are using, vscode, you can just install the markdownlinq extension and you should get the issues as well.
Member
|
Thanks a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
title
PR Context
@TravisEz13 told me to do this
Travis if your reading this just know I have to update the other file please no merge yet
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests