Skip to content

Use https in URLs where available#8622

Merged
TravisEz13 merged 40 commits intoPowerShell:masterfrom
xtqqczze:https
Jan 24, 2019
Merged

Use https in URLs where available#8622
TravisEz13 merged 40 commits intoPowerShell:masterfrom
xtqqczze:https

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jan 11, 2019 •
edited
Loading

PR Summary

Use https in URLS across the repository where the domain serves content by https.

PR Checklist

iSazonov
iSazonov reviewed Jan 11, 2019
View reviewed changes
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jan 11, 2019
@iSazonov
Copy link
Collaborator

iSazonov commented Jan 11, 2019

How can we really check that all the links work?

@vexx32
Copy link
Collaborator

vexx32 commented Jan 11, 2019

@iSazonov if I recall correctly a recent PR added link verifications to the CI-static-analysis check.

@iSazonov
Copy link
Collaborator

iSazonov commented Jan 11, 2019

@vexx32 There is only md-file check.

mdspell '**/*.md' '!**/Pester/**/*.md'

@RDIL
Copy link
Contributor

RDIL commented Jan 11, 2019

idea stolen from me haha

@RDIL
Copy link
Contributor

RDIL commented Jan 11, 2019

@iSazonov no you are wrong and @vexx32 is right, I added a link check task but it is only for markdown files.

RDIL
RDIL approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, somebody needs to look over the static analysis logs however.

@RDIL
Copy link
Contributor

RDIL commented Jan 15, 2019 

2019-01-12T17:16:07.6158436Z __UNELEVATED_TESTS_THE_END__
2019-01-12T17:16:08.2464998Z 1 tests in test/powershell failed
2019-01-12T17:16:08.2465114Z At D:\a\1\s\build.psm1:1348 char:13
2019-01-12T17:16:08.2465163Z +             throw "$($x.'test-results'.failures) tests in $TestArea f ...
2019-01-12T17:16:08.2465227Z +             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-01-12T17:16:08.2465281Z     + CategoryInfo          : OperationStopped: (1 tests in test/powershell failed:String) [], RuntimeException
2019-01-12T17:16:08.2465330Z     + FullyQualifiedErrorId : 1 tests in test/powershell failed
2019-01-12T17:16:08.2465801Z  
2019-01-12T17:16:08.2465857Z Upload CoreCLR Non-Admin test results
2019-01-12T17:16:08.2465917Z WARNING: Not running in appveyor, skipping upload of test results: D:\a\1\s\TestsResultsNonAdmin.xml
2019-01-12T17:16:08.2466187Z TEST FAILURES
2019-01-12T17:16:08.2466242Z Description: Should match native commands
2019-01-12T17:16:08.2466300Z Name:        Get-Command CI tests.-UseFuzzyMatch tests.Should match native commands
2019-01-12T17:16:08.2466363Z message:
2019-01-12T17:16:08.2466427Z Expected 'PING.EXE' to be found in collection @('gin', 'gin', 'gin', 'pfn', 'dir', 'popd', 'pushd', 'cpi', 'gi', 'iex'), but it was not found.
2019-01-12T17:16:08.2466485Z stack-trace:
2019-01-12T17:16:08.2466561Z at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Utility\Get-Command.Tests.ps1: line 20
2019-01-12T17:16:08.2466620Z 20:             $cmds.Name | Should -Contain $ping
2019-01-12T17:16:08.2540098Z ##[error]PowerShell exited with code '1'.

@iSazonov
Copy link
Collaborator

iSazonov commented Jan 15, 2019

@RDIL Please rebase to pass CIs.

@RDIL
Copy link
Contributor

RDIL commented Jan 15, 2019 •
edited
Loading

@iSazonov this isn't my PR, just saying what the error message is. 🔨

@iSazonov
Copy link
Collaborator

iSazonov commented Jan 15, 2019

Sorry.
@xtqqczze Please rebase to pass CIs.

TravisEz13
TravisEz13 reviewed Jan 16, 2019
View reviewed changes
TravisEz13
TravisEz13 reviewed Jan 16, 2019
View reviewed changes
TravisEz13
TravisEz13 reviewed Jan 16, 2019
View reviewed changes
TravisEz13
TravisEz13 reviewed Jan 16, 2019
View reviewed changes
@xtqqczze xtqqczze mentioned this pull request Jan 18, 2019
Merged
8 tasks
@xtqqczze
Merge branch 'master' into https
01f8f79
@xtqqczze
Revert change to \AppImageThirdPartyNotices.txt
b04043c 
Revert change to Unicode license in `assets\AppImageThirdPartyNotices.txt`
@TravisEz13 TravisEz13 merged commit 8635288 into PowerShell:master Jan 24, 2019
@TravisEz13
Copy link
Member

TravisEz13 commented Jan 24, 2019

Thanks for your contribution

@xtqqczze xtqqczze deleted the https branch February 1, 2019 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@BrucePay BrucePay Awaiting requested review from BrucePay

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

@joeyaiello joeyaiello Awaiting requested review from joeyaiello

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

+2 more reviewers

@dabutvin dabutvin dabutvin left review comments

@RDIL RDIL RDIL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xtqqczze @iSazonov @vexx32 @RDIL @TravisEz13 @dabutvin

Comments