Skip to content

Style: Change String to string type alias#8573

Merged
daxian-dbw merged 7 commits intoPowerShell:masterfrom
iSazonov:style-string-type-alias
Jan 7, 2019
Merged

Style: Change String to string type alias#8573
daxian-dbw merged 7 commits intoPowerShell:masterfrom
iSazonov:style-string-type-alias

Conversation

@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Dec 31, 2018

PR Summary

Change String to string type alias.

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 31, 2018
@iSazonov iSazonov force-pushed the style-string-type-alias branch from 02981a8 to eb64ca5 Compare December 31, 2018 18:50
@iSazonov iSazonov force-pushed the style-string-type-alias branch from eb64ca5 to f2ead9b Compare December 31, 2018 20:11
@iSazonov
Copy link
Collaborator Author

iSazonov commented Jan 6, 2019

@daxian-dbw You comments is addressed and merge conflict is resolved.

Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit b8f9532 into PowerShell:master Jan 7, 2019
@iSazonov iSazonov deleted the style-string-type-alias branch January 7, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments