Skip to content

Fix typo in AMSI test #8561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 4 commits into from
Dec 29, 2018
Merged

Fix typo in AMSI test #8561

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd89af0
Revert change in AMSI test
iSazonov Dec 29, 2018
69cdb8c
[Feature]
iSazonov Dec 29, 2018
59d2df5
Fix cmdlet name
iSazonov Dec 29, 2018
3c159a2
[Feature]
iSazonov Dec 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/powershell/Modules/Microsoft.PowerShell.Security/AmsiInterface.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ try

$EICAR_STRING_B64 = "awZ8EmMWc3JjaAdvY2lrBgcbY20aBHBwGgROF3Z6cHJhHmBncn13cmF3HnJ9Z3plemFmYB5ndmBnHnV6f3YSF3sYexk= "
$bytes = [System.Convert]::FromBase64String($EICAR_STRING_B64)
$EICAR_STRING = -join ($bytes | ForeEach-Object { [char]($_ -bxor 0x33) })
Copy link
Collaborator

@vexx32 vexx32 Dec 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue isn't the use of alias or not; the issue is that the cmdlet name was misspelled (ForeEach-Object should be ForEach-Object). I think removing the alias was the right move; we should keep the proper full cmdlet name.

Why did this not come up in the initial PR?

Copy link
Collaborator Author

@iSazonov iSazonov Dec 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll try cmdlet name. In initial PR we did not run all tests with [Feature].

Copy link
Member

@SteveL-MSFT SteveL-MSFT Dec 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should be able to detect that the change is within a Feature test and automatically run those, let me think about this.

Copy link
Collaborator Author

@iSazonov iSazonov Dec 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoreFX team uses a bot to run tests. We could do the same.
Perhaps it makes sense to run short set of tests initially for speed. Then always run full set of tests before merge.

Copy link
Member

@SteveL-MSFT SteveL-MSFT Dec 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iSazonov that's a good idea. Maintainers can request bot to run full set of tests after review is approved and CI tests pass. Let me work on this.

$EICAR_STRING = -join ($bytes | ForEach-Object { [char]($_ -bxor 0x33) })
{ Invoke-Expression -Command "echo '$EICAR_STRING'" } |
Should -Throw -ErrorId "ScriptContainedMaliciousContent,Microsoft.PowerShell.Commands.InvokeExpressionCommand"
}
Expand Down