Remove use of cmdlet aliases from .\test\powershell#8546
Remove use of cmdlet aliases from .\test\powershell#8546iSazonov merged 7 commits intoPowerShell:masterfrom
Conversation
Remove use of cmdlet aliases from .\test\powershell\* and suppress warnings from PSScriptAnalyzer if use of a cmdlet alias is necessary for tests.
|
@xtqqczze Thanks for your contribution! We never used message suppressions and I would delete its. In the case we could fast merge. If you think that this could be useful please open new issue for discussion. |
Remove PSAvoidUsingCmdletAliases message suppression.
|
@xtqqczze Sorry, I meant that comments is not needed too. We don't have |
|
@iSazonov When using vscode with the ms-vscode.powershell extension enabled, rule violations from PSScriptAnalyzer testing are listed as warnings in the 'Problems' pane, for example: Certain tests have comments explaining a rule should be ignored, because at the present time rules can only be suppressed on a file level for Pester tests. These comments help identify spurious warnings in the vscode 'Problems' pane and provide a placeholder for future implementation of rule suppression at a test level. |
|
@xtqqczze I see your point. These comments is obvious and don't add value but reduce readability. Your proposal will be useful after we (1) get implementation of local suppressions and (2) force CIs. Today I suggest split replacing aliases and suppressing messages. For second work you could open a tracking issue if you want. |
|
@xtqqczze Thanks for your contribution! |
* Avoid use of sleep alias (follow-up to PowerShell#8546) * Specify default parameter name * Shorten overly specific comments
* Avoid use of sleep alias (follow-up to #8546) * Specify default parameter name * Shorten overly specific comments
PR Summary
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests