Code cleanup: Add space after closing brace where needed#8530
Merged
iSazonov merged 81 commits intoPowerShell:masterfrom Dec 24, 2018
Merged
Code cleanup: Add space after closing brace where needed#8530iSazonov merged 81 commits intoPowerShell:masterfrom
iSazonov merged 81 commits intoPowerShell:masterfrom
Conversation
11 tasks
264254e to
81e6e8b
Compare
Collaborator
|
@SteveL-MSFT Please resolve the merge conflict. |
81e6e8b to
7e7a9cc
Compare
Member
Author
|
Let's try to get this reviewed and merge before merging other PRs otherwise it's going to be a merge conflict target |
iSazonov
reviewed
Dec 23, 2018
src/System.Management.Automation/cimSupport/cmdletization/ScriptWriter.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/cimSupport/cmdletization/ScriptWriter.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/cimSupport/cmdletization/ScriptWriter.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterface.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterfacePromptForChoice.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterfaceSecurity.cs
Outdated
Show resolved
Hide resolved
Collaborator
|
@SteveL-MSFT I think we need fix only my last comments about "while". Rest is minor. |
Member
Author
|
@iSazonov thanks for taking the time to review this in detail. I'll update the rules in my script and will rerun. |
7e7a9cc to
3e0cb12
Compare
iSazonov
approved these changes
Dec 23, 2018
11 tasks
3e0cb12 to
c8d7f98
Compare
Collaborator
|
It was not easy, but I believe that it will facilitate our work in the future. |
Collaborator
|
@SteveL-MSFT I'd merge if @daxian-dbw is absent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Using this script each folder is a separate commit making it easier to review.
The regular expression looks for any closing brace not followed by:
| catch, else, finally, another closing brace, newline, space, hash, slash (comment), * (comment)
In addition, because .NET RegEx doesn't support look behind, I skip any closing braces that are part of: { get; set; }
Some of the Copyright notices show changed because git resaved the file without BOM.
Manually reviewed all the changes.
Related #8500
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests