Help function should only pass content to pager if content was found#8528
Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom Jan 8, 2019
Merged
Help function should only pass content to pager if content was found#8528adityapatwardhan merged 1 commit intoPowerShell:masterfrom
Help function should only pass content to pager if content was found#8528adityapatwardhan merged 1 commit intoPowerShell:masterfrom
Conversation
iSazonov
approved these changes
Dec 24, 2018
Collaborator
|
Restart CI-windows. |
anmenaga
approved these changes
Dec 26, 2018
adityapatwardhan
approved these changes
Jan 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
helpfunction assumes that if a list isn't returned then it's help content and pipes it to the pager. It does not consider the case where the help content wasn't found. Fix is to use the pager only if help content was returned.PR Summary
Fix #8524
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests