Update examples for hosting PSCore and remove old outdated examples before 6.0.0 RTM#8472
Merged
daxian-dbw merged 10 commits intoPowerShell:masterfrom Jan 11, 2019
Merged
Conversation
…e .Net Core 2.2 example and update APIs being called
iSazonov
reviewed
Dec 16, 2018
daxian-dbw
requested changes
Dec 18, 2018
…to updateExamples # Conflicts: # docs/host-powershell/sample-dotnet1.1/Logic/UseRunspace.cs # docs/host-powershell/sample-dotnet1.1/MyApp/Program.cs # docs/host-powershell/sample-dotnet2.0-powershell.beta.1/Logic/UseRunspace.cs # docs/host-powershell/sample-dotnet2.0-powershell.beta.1/MyApp/Program.cs
… sample and rename to just sample
Contributor
Author
|
@daxian-dbw I addressed your comments, the PR is up for re-review |
daxian-dbw
approved these changes
Jan 11, 2019
Member
daxian-dbw
left a comment
There was a problem hiding this comment.
Thanks @bergmeister for the updates!
I updated the Special Hosting Scenario section of the readme. Everything else looks great!
29a07fe to
1d72d17
Compare
Contributor
Author
|
Thanks @daxian-dbw . Do you mind explaining why the microsoft/nanoserver image is using a Core version of Windows PowerShell 5? To me it looks like a pre-Alpha version of PSCore, is this just for legacy or is this version of PowerShell supported/maintained? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update project and NuGet packages to
netcoreapp2.1and6.1.1NuGet packages, old projects before 6.0 RTM time are being removed.I checked it works by running
dotnet runon the project.cc @rkeithhill
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests