Add macOS files to .gitignore#8456
Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom Jan 15, 2019
RDIL:patch-2
Merged
Conversation
Contributor
Author
|
@iSazonov @PaulHigin @SteveL-MSFT requesting review |
SteveL-MSFT
reviewed
Jan 11, 2019
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Looks ok to me, but I've never generated any of these files that they would accidentally be included in a commit
Contributor
Author
|
They are all pretty common for avid Mac users |
TravisEz13
reviewed
Jan 15, 2019
| .TemporaryItems | ||
| .Trashes | ||
| .VolumeIcon.icns | ||
| .com.apple.timemachine.donotpresent |
Member
There was a problem hiding this comment.
some of these files should only be present at the root of the drive, but I'm not complaining unless they cause issues.
Contributor
Author
There was a problem hiding this comment.
Hah, funny you should mention that, I have my PowerShell install on the root drive!!
Member
There was a problem hiding this comment.
Just a couple of them I had to lookup.
TravisEz13
approved these changes
Jan 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Apple files have no place here at Microsoft
Label
I would suggest CL-Tools.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.