Make scriptblock-based calculated properties work again in ConvertTo-Html#8427
Merged
iSazonov merged 3 commits intoPowerShell:masterfrom Jan 9, 2019
Merged
Conversation
Make scriptblock-based calculated properties work again.
iSazonov
reviewed
Dec 8, 2018
Collaborator
iSazonov
left a comment
There was a problem hiding this comment.
@mklement0 Please add a commit with [Feature] in title to run full test set.
Collaborator
There was a problem hiding this comment.
I'd remove the obvious comment and enhance comment in line 346.
Contributor
Author
There was a problem hiding this comment.
@iSazonov: Done. Is it sufficient to add "[Feature]" in the first line of a commit message once?
iSazonov
approved these changes
Dec 8, 2018
Closed
11 tasks
adityapatwardhan
approved these changes
Dec 10, 2018
11 tasks
Collaborator
|
@mklement0 Sorry, I lost the PR :-( Do we ready to merge? |
Contributor
Author
|
@iSazonov: From my perspective, yes. Can you squash-merge, or do I need to consolidate the commits myself? |
Collaborator
|
@mklement0 Maintainers can squash and merge as needed. Thanks for your contribution! |
Contributor
Author
|
That's good to know, @iSazonov - thanks for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #6993
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests