[improvement] removed comments after closing brackets#8344
Merged
iSazonov merged 1 commit intoPowerShell:masterfrom Dec 8, 2018
Meir017:improvements/clean-comments
Merged
[improvement] removed comments after closing brackets#8344iSazonov merged 1 commit intoPowerShell:masterfrom Meir017:improvements/clean-comments
iSazonov merged 1 commit intoPowerShell:masterfrom
Meir017:improvements/clean-comments
Conversation
iSazonov
approved these changes
Nov 29, 2018
Collaborator
|
@Meir017 In future please keep PR as small as possible: small PR can be reviewed fast. You could create some PRs by folder/projects. Another approach is to make some commits (by 10-15 files) in one PR that allow fast review commit by commit or break work into several people. |
Contributor
Author
|
@iSazonov I thought about splitting it into multiple pull-requests but since it was just a regex-replace action I thought it might be easier to do it this way. |
Collaborator
|
@Meir017 You could make some commits to allow commit-by-commit review. |
Collaborator
|
Double checked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Removed all comments that appear after a closing bracket
idea came from #8324 (comment)
since any time a pull-request will be authored on a file the contains these comments the pull-request creator will be asked to remove them I thought might be a good idea to do this once and finish with it
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests