Cleanup updatablehelpsystem and enable XSD validation on MAML help content#8335
Merged
adityapatwardhan merged 6 commits intoPowerShell:masterfrom Nov 29, 2018
Merged
Conversation
Collaborator
Author
|
Tests failed with "The Help content XSD file cannot be found in C:\projects\powershell\src\powershell-win-core\bin\Release" I see that Windows PowerShell has Should we restore this or remove schemas support? |
Member
|
@iSazonov Thanks for this PR. We should bring back the schema files as XSD validation seems to be supported in CoreCLR now. |
Collaborator
Author
|
@adityapatwardhan Please point me where I can get this files from. Can I copy them to the repo from Windows PowerShell directory? |
74aca01 to
2bf264c
Compare
Collaborator
Author
|
@adityapatwardhan Schemas added. |
adityapatwardhan
approved these changes
Nov 29, 2018
Member
adityapatwardhan
left a comment
There was a problem hiding this comment.
Please update the title to mention enable XSD validation of maml help
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Related #3565 and #4357.
Easily review commit by commit:
usingstatements.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests