Remove old 'customPSSnapInType' parameter from PSSnapInInfo()#8333
Merged
iSazonov merged 2 commits intoPowerShell:masterfrom Nov 26, 2018
Merged
Remove old 'customPSSnapInType' parameter from PSSnapInInfo()#8333iSazonov merged 2 commits intoPowerShell:masterfrom
iSazonov merged 2 commits intoPowerShell:masterfrom
Conversation
daxian-dbw
approved these changes
Nov 26, 2018
Member
daxian-dbw
left a comment
There was a problem hiding this comment.
Looks good. Please remove the unneeded resource string.
| { | ||
| throw PSTraceSource.NewArgumentException( | ||
| "customPSSnapInType", | ||
| MshSnapInCmdletResources.CustomPSSnapInNotSupportedInPowerShellCore); |
Member
There was a problem hiding this comment.
Can we remove this resource string from the .resx file?
iSazonov
added a commit
to iSazonov/PowerShell
that referenced
this pull request
Nov 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Related #3565 and #4357.
CustomPSSnapIn is not supported in PowerShell Core and we can remove the old 'customPSSnapInType' parameter from internal API.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests