I think a right fix is to remove the parameter on Unix-s.

Interesting. I hadn't considered that.

First thoughts on the effects of removing the parameter on non-Windows platforms.

That would entirely prevent -Persist confusion while using the shell or writing a script on a non-Windows machine 👍

However, suppose someone writes a script calling New-PSDrive -Persist ... on Windows. Then they attempt to run the script on MacOS. Is it better for debugging to throw a ParameterBindingException or a PlatformNotSupportedException?

I think the PlatformNotSupportedException is self-explanatory. OTOH, maybe the ParameterBindingException would warrant an explanation in the cmdlet help. If so, do you keep the Persist parameter help to explain that on non-Windows machines, even though the parameter isn't available? Perhaps the scenario is contrived, but worth a thought at least.

In terms of implementation, I think removing the parameter would require wrapping the Persist property in a #if !UNIX directive. Therefore, every reference to that property would also need to be wrapped in a #if !UNIX directive. For many references, I would prefer not do that. Though In this case, there is only one reference to Persist and this cmdlet seems quite stable.

What do you think?

We already have an experience with removing unsupported cmdlets and parameters on Unix platforms. User will get "A parameter cannot be found ..." error that looks good. See #4922 - implemented after the comment #4897 (comment)

Perfect example to follow 👌 Thank you.

@lukexjeremy In next time please don't put your commits in master branch - create a new work branch for every new PR.

Darn. Will fix those failing checks later today.

@lukexjeremy Please open new issue in https://github.com/PowerShell/PowerShell-Docs to document the change.

And add here new empty commit with [Feature] header to run all tests.

@lukexjeremy Please reopen the PR and we will merge.

👍

@lukexjeremy You removed commits. Could you restore your branch?

@lukexjeremy Thanks for your contribution!

Come back with new contributions!

Thanks for your help too. Will do and looking forward to the next contribution.

You could look issues with Up-for-Grabs. Also we have an issue to hide parameters and cmdlets which is not still implemented on Unix. There are more such examples.